Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small changes and header css #1300

Merged
merged 11 commits into from
Dec 3, 2024
Merged

Small changes and header css #1300

merged 11 commits into from
Dec 3, 2024

Conversation

amy-corson-ibigroup
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup commented Nov 6, 2024 •
edited
Loading

Description:

  • Add margin to loading spinner to avoid clipping.
  • Fix small regression on headsign selector in pattern viewer, to avoid weird spacing on buttons.
  • Clean up navbar css to avoid clipping on all screen sizes.
  • Sort css
  • Fix cut-off in pattern viewer stops container

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

binh-dam-ibigroup
binh-dam-ibigroup requested changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the cleanup! Could you address the agency logo situation please?

lib/components/app/app.css Show resolved Hide resolved
@amy-corson-ibigroup
Copy link
Contributor Author

Added to this PR: tried a new approach to the height of the stops ol in the pattern viewer, as the current approach is resulting in the last stop being cut off on most screen sizes.

miles-grant-ibigroup

This comment was marked as outdated.

Sign in to view

@binh-dam-ibigroup
Copy link
Collaborator

That being said could I ask that this PR be put on hold until that other PR is ready to merge and that they're then merged at the same time?

Any specific reason to delay if this PR is ready?

miles-grant-ibigroup
miles-grant-ibigroup requested changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-11-26 at 11 19 41 AM This is what the default config looks like. The left-padding is too strong and something is wrong with the centering!

@amy-corson-ibigroup
Copy link
Contributor Author

Shortened the gap which should fix the padding issue! The centering was because of a padding-top in the example css, which I removed

miles-grant-ibigroup
miles-grant-ibigroup approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm scared but I'm also excited

@amy-corson-ibigroup amy-corson-ibigroup merged commit 74f8656 into dev Dec 3, 2024
9 checks passed
@amy-corson-ibigroup amy-corson-ibigroup deleted the small-changes-and-header-css branch December 3, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@amy-corson-ibigroup amy-corson-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amy-corson-ibigroup @binh-dam-ibigroup @miles-grant-ibigroup